Fix bfres and byml alignment in SarcAlignment.cs#1
Merged
ArchLeaders merged 1 commit intoEPD-Libraries:masterfrom Jul 15, 2025
Merged
Fix bfres and byml alignment in SarcAlignment.cs#1ArchLeaders merged 1 commit intoEPD-Libraries:masterfrom
ArchLeaders merged 1 commit intoEPD-Libraries:masterfrom
Conversation
Member
|
Some formatting errors, but looks pretty sound, thanks! I should probably add an external API to add custom alignment cases at runtime. I'd be curious if you have any thoughts on that. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encountered an issue when writing archives containing
BFRESfiles, this PR adds a case to theSarcAlignment.csestimate function, manually settingBFRESandBYMLalignments.Also includes an addition to the unit tests to ensure that archives containing
BFRESfiles match byte-perfectly after being re-written.All tests, including the new one, pass in this commit.