Skip to content

Use central differencing in solenoidal correction and tendency calculation#425

Merged
matt-frey merged 6 commits intomainfrom
use-central-differencing
Nov 24, 2022
Merged

Use central differencing in solenoidal correction and tendency calculation#425
matt-frey merged 6 commits intomainfrom
use-central-differencing

Conversation

@matt-frey
Copy link
Member

@matt-frey matt-frey commented Nov 21, 2022

This PR

  • use FD for performing vertical derivatives
  • fixes the subroutine diffz
  • adds more unit tests for diffz and central_diffz

@matt-frey matt-frey added bug Something isn't working 3D Issues and pull requests related to the 3D version labels Nov 21, 2022
@matt-frey matt-frey self-assigned this Nov 21, 2022
@matt-frey matt-frey added the unit test Unit tests label Nov 24, 2022
@matt-frey matt-frey marked this pull request as ready for review November 24, 2022 11:09
Copy link
Collaborator

@daviddritschel daviddritschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor questions - can commit if they are not a concern

@matt-frey matt-frey merged commit 8e50dc4 into main Nov 24, 2022
@matt-frey matt-frey deleted the use-central-differencing branch November 24, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3D Issues and pull requests related to the 3D version bug Something isn't working unit test Unit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants