Skip to content

Fix MPI related issues#453

Merged
matt-frey merged 25 commits into3d-mpi-modelfrom
halo-swap-in-advection
Apr 18, 2023
Merged

Fix MPI related issues#453
matt-frey merged 25 commits into3d-mpi-modelfrom
halo-swap-in-advection

Conversation

@matt-frey
Copy link
Member

@matt-frey matt-frey commented Apr 15, 2023 •
edited
Loading

This PR

  • adds missing parcel halo swap calls
  • adds parallelism to the time step calculation
  • adds missing field halo fill calls
  • adds missing updates of the total number of parcels

Close #454.

@matt-frey matt-frey added bug Something isn't working 3D Issues and pull requests related to the 3D version MPI MPI related issues and pull requests labels Apr 15, 2023
@matt-frey matt-frey self-assigned this Apr 15, 2023
@matt-frey matt-frey added this to the 0.13.0 milestone Apr 15, 2023
@matt-frey matt-frey changed the title Add missing parcel halo swap calls Add missing parcel halo swap calls and update time step calculation Apr 15, 2023
@matt-frey matt-frey linked an issue Apr 15, 2023 that may be closed by this pull request
Fix gradb calculation periodicity (and think of other gradient operations where this may apply) #454
Closed
@matt-frey matt-frey requested a review from sjboeing April 15, 2023 14:15
@matt-frey matt-frey marked this pull request as ready for review April 15, 2023 14:16
@matt-frey matt-frey changed the title Add missing parcel halo swap calls and update time step calculation Fix MPI related issues Apr 17, 2023
@matt-frey matt-frey merged commit 30cb481 into 3d-mpi-model Apr 18, 2023
@matt-frey matt-frey deleted the halo-swap-in-advection branch April 18, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjboeing sjboeing Awaiting requested review from sjboeing

Assignees

@matt-frey matt-frey

Labels

3D Issues and pull requests related to the 3D version bug Something isn't working MPI MPI related issues and pull requests

Projects

None yet

Milestone

0.13.0

Development

Successfully merging this pull request may close these issues.

Fix gradb calculation periodicity (and think of other gradient operations where this may apply)

2 participants

@matt-frey @sjboeing