Conversation
sjboeing
left a comment
There was a problem hiding this comment.
Thanks for writing this Matthias! I can see why you initially went for the other approach, but thought it would be worth trying to get rid of the compiler warnings. Not quite sure whether to do anything (by default) with the values of the output fields at z=-1 and z=nz+1.
|
We could also get rid of these warnings by explicitly creating a temporary variable ourselves. |
|
What do you think is best practice/most efficient? I would be OK with either solution. Guess this is the next one to merge after the period BCs PR. |
|
Avoiding temporary arrays is definitely more efficient as we do not copy memory. The indices |
|
My suggested change: 5759bce |
|
Let's use the extrapolation, which I agree should be safer. |
…raries-debug-mode
Fortran creates temporary arrays when passing sub-ranges to subroutines.