Conversation
matt-frey
added
3D
Fix unit-tests -- register missing timer and fix function call
sjboeing
reviewed
Jul 19, 2023
sjboeing
reviewed
Jul 19, 2023
sjboeing
reviewed
Jul 19, 2023
sjboeing
reviewed
Jul 19, 2023
sjboeing
reviewed
Jul 19, 2023
sjboeing
reviewed
Jul 19, 2023
sjboeing
reviewed
Jul 19, 2023
sjboeing
reviewed
Jul 19, 2023
sjboeing
reviewed
Jul 19, 2023
sjboeing
reviewed
Jul 19, 2023
sjboeing
reviewed
Jul 19, 2023
Collaborator
sjboeing
left a comment
sjboeing
left a comment
There was a problem hiding this comment.
Great work, Matthias! I wasn't always sure whether world (rather than cart) was the right communicator. In these cases, I have put a note, but you may have figured these out already. Not sure if it is easy/necessary to run all the comm unit tests across 2 nodes to double-check all is OK.
Member
Author
|
Indeed, I had to fix 3 unit-tests with respect to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some program instances the MPI_COMM_WORLD MPI rank does not match the Cartesian MPI rank because the
reorderflag does not seem to be taken into account by the MPI implementations despite the MPI specifications (see https://www.mpi-forum.org/docs/mpi-1.1/mpi-11-html/node133.html).