Skip to content

Do not use MPI_COMM_WORLD as default in collectives#515

Merged
matt-frey merged 2 commits into3d-mpi-modelfrom
communicator-in-collectives
Jul 20, 2023
Merged

Do not use MPI_COMM_WORLD as default in collectives#515
matt-frey merged 2 commits into3d-mpi-modelfrom
communicator-in-collectives

Conversation

@matt-frey
Copy link
Member

@matt-frey matt-frey commented Jul 20, 2023

To avoid errors between the default communicator MPI_COMM_WORLD and the Cartesian communicator, we force code developers to explicitly pass the communicator to the MPI reductions.

@matt-frey matt-frey added enhancement / optimisation Improve algorithm or behaviour 3D Issues and pull requests related to the 3D version MPI MPI related issues and pull requests labels Jul 20, 2023
@matt-frey matt-frey added this to the 0.13.0 milestone Jul 20, 2023
@matt-frey matt-frey self-assigned this Jul 20, 2023
@matt-frey matt-frey requested a review from sjboeing July 20, 2023 08:58
Copy link
Collaborator

@sjboeing sjboeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@matt-frey matt-frey merged commit 81a849f into 3d-mpi-model Jul 20, 2023
@matt-frey matt-frey deleted the communicator-in-collectives branch July 20, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3D Issues and pull requests related to the 3D version enhancement / optimisation Improve algorithm or behaviour MPI MPI related issues and pull requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants