Conversation
matt-frey
added
feature request
sjboeing
reviewed
Dec 11, 2023
sjboeing
reviewed
Dec 11, 2023
sjboeing
reviewed
Dec 11, 2023
Collaborator
sjboeing
left a comment
sjboeing
left a comment
There was a problem hiding this comment.
Just left some comments. Looks good though I was wondering if we can avoid findloc.
sjboeing
approved these changes
Dec 11, 2023
Collaborator
sjboeing
left a comment
sjboeing
left a comment
There was a problem hiding this comment.
Happy for you to merge, Matthias. I was wondering (see slack) if there is an argument for using a temporary integer array here, rather than reusing an array, if we use temporary arrays elsewhere (and this is not the point in the code where the memory footprint is largest).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write parcel merger statistics to the netCDF file.