Skip to content

Damping implementation#549

Merged
sjboeing merged 25 commits intodevfrom
simple_damping_all
Jan 18, 2024
Merged

Damping implementation#549
sjboeing merged 25 commits intodevfrom
simple_damping_all

Conversation

@sjboeing
Copy link
Collaborator

@sjboeing sjboeing commented Jan 9, 2024

Work in progress

@matt-frey matt-frey added feature request New feature or request 3D Issues and pull requests related to the 3D version labels Jan 9, 2024
Copy link
Member

@matt-frey matt-frey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good. However, I suggest some changes. Also, could you change to 4 white space characters instead of 2 as we use 4 throughout EPIC? Thanks.

Copy link
Member

@matt-frey matt-frey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better now! Thanks! I still have some suggestions. Can you maybe also use spaces between opertions, like a = b + c instead of a=b+c. It helps to improve readability. We usually also add spaces for if-statements, i.e. "if (...)" instead of "if(...)".

@sjboeing
Copy link
Collaborator Author

@matt-frey: Let me know if the layout etc. looks OK now.

Copy link
Member

@matt-frey matt-frey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks generally good now. Thanks for the hard work. There are a few places where you could do some code alignment though. I also have a question regarding the calculation of the strain magnitude.

@matt-frey matt-frey marked this pull request as ready for review January 16, 2024 08:58
Copy link
Member

@matt-frey matt-frey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

@sjboeing sjboeing merged commit 12e99f8 into dev Jan 18, 2024
@matt-frey matt-frey deleted the simple_damping_all branch August 2, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3D Issues and pull requests related to the 3D version feature request New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants