Conversation
matt-frey
left a comment
There was a problem hiding this comment.
Looks generally good. However, I suggest some changes. Also, could you change to 4 white space characters instead of 2 as we use 4 throughout EPIC? Thanks.
matt-frey
left a comment
There was a problem hiding this comment.
Looks much better now! Thanks! I still have some suggestions. Can you maybe also use spaces between opertions, like a = b + c instead of a=b+c. It helps to improve readability. We usually also add spaces for if-statements, i.e. "if (...)" instead of "if(...)".
that halo swapping is needed in any case
|
@matt-frey: Let me know if the layout etc. looks OK now. |
matt-frey
left a comment
There was a problem hiding this comment.
It looks generally good now. Thanks for the hard work. There are a few places where you could do some code alignment though. I also have a question regarding the calculation of the strain magnitude.
Work in progress