Browser Card #110
Merged
Browser Card #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed Browser type and reducer -- no longer needed
Checkpoint -- website shows up in browser card
…n url history is changed
Open
17 tasks
nelsonni
requested changes
May 28, 2020
Member
nelsonni
left a comment
nelsonni
left a comment
There was a problem hiding this comment.
Several items need to be addressed before this PR can be accepted and merged. Specifically, refactoring needs to be done to reduce the number of useState hooks being created and managed within BrowserComponent, and card creation needs to rely on the standard loadCard() function.
nelsonni
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browser Card allows users to visit websites while working within Synectic. Contains an address bar that displays the currently loaded URL, and allows users to load websites through manually entered URLs. Users can navigate back and forward in browser session history, and reload websites.
Addresses issue #39