Improvements related to multidimNcFiles#169
Merged
ChrisJohnNOAA merged 9 commits intoERDDAP:mainfrom Jul 11, 2024
Merged
Conversation
Specifically requests with no data in the source files (only globals, jexl script, or variables) will now function.
This is used in readMultidimNc and if set to false (defaults to true, so prior to this change was always true), could provide significant speed up to queries for some EDDTableFromMultidimNcFiles datasets.
This includes updates like loading and using constraints before loading the remaining variables. In the test queries, the new code is faster, but the improvement is small compared to setting removeMVRows to false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Actually use the removeMVRows dataset parameter now (which allows turning off the related logic). This can provide a significant performance increase.
Also refactor the general processing while loading files including performance improvements.
Fixes #152
Type of change
Please delete options that are not relevant.
Checklist before requesting a review