Skip to content

Release 2.25#219

Merged
ChrisJohnNOAA merged 9 commits intoERDDAP:mainfrom
ChrisJohnNOAA:release_2.25
Oct 17, 2024
Merged

Release 2.25#219
ChrisJohnNOAA merged 9 commits intoERDDAP:mainfrom
ChrisJohnNOAA:release_2.25

Conversation

@ChrisJohnNOAA
Copy link
Contributor

Description

Changes for the 2.25 release including updating version numbers, some documentation updates, excluding some unnecessary files from the war, and defaulting the SharedWatchService to on.

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@srstsavage
Copy link
Collaborator

@ChrisJohnNOAA For download-maven-plugin, I'm noticing some odd behavior when using unpackWhenChanged (unextracted zip files remain in the output directory on every other run) that I'd like to fix before setting unpackWhenChanged to true. I think it still makes sense to upgrade download-maven-plugin to 1.11.0 so download progress can be quieted with --no-transfer-progress, but my vote would be to hold off on unpackWhenChanged until that behavior is fixed.

@ChrisJohnNOAA
Copy link
Contributor Author

@ChrisJohnNOAA For download-maven-plugin, I'm noticing some odd behavior when using unpackWhenChanged (unextracted zip files remain in the output directory on every other run) that I'd like to fix before setting unpackWhenChanged to true. I think it still makes sense to upgrade download-maven-plugin to 1.11.0 so download progress can be quieted with --no-transfer-progress, but my vote would be to hold off on unpackWhenChanged until that behavior is fixed.

Sure. I switched it back to unpack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants