Time optimization and modernization#351
Merged
ChrisJohnNOAA merged 3 commits intoERDDAP:mainfrom Sep 9, 2025
Merged
Conversation
… functions, this allows us to get it once (instead of once per row) when handling a lot of data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GregorianCalendar->java.time (mostly ZonedDateTime). This is an improvement in performance and memory usage along with simplifying our code (there's more to be done, I was trying to keep the impact outside of Calendar2 to a minimum in this pull) and moving to a modern standard.
One important thing to note, there are 2 test datasets that were impacted by this change. I don't know how common their configuration is for real datasets, but if you are using days (or smaller) since 1592 (or any earlier time like the year 0000) for a time column, you will likely want to add the attribute:
<att name="legacy_time_adjust">true</att>to that variable.
This should keep the variable consistent with the old way of handling datetime.
Type of change
Please delete options that are not relevant.
Checklist before requesting a review