Skip to content

Conversation

@galabovaa
Copy link
Contributor

This only affects -DCUPDLP_FIND_CUDA=ON.
For all of our test setups CUPDLP_FIND_CUDA was not required at all on Windows.
I modified it anyway, just in case there are problems with the default CMake find CUDA on Windows, possibly Windows server since CUPDLP_FIND_CUDA was required for linux servers.
Users should set -DCMAKE_CUDA_PATH="..." when configuring CMake if they use -DCUPDLP_FIND_CUDA=ON

@galabovaa
Copy link
Contributor Author

I see one more bazel tsan failure meaning I have more work there.

@galabovaa galabovaa requested a review from jajhall May 15, 2025 13:10
@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.06%. Comparing base (87fe0a3) to head (e9c99c3).
Report is 16 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #2339      +/-   ##
==========================================
- Coverage   79.29%   79.06%   -0.23%     
==========================================
  Files         345      345              
  Lines       84375    84387      +12     
==========================================
- Hits        66907    66723     -184     
- Misses      17468    17664     +196     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jajhall jajhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can believe that WIN32 and CUDA aren't things we want to combine, and otherwise you're just adding places to look

So, looks fine to me

@galabovaa
Copy link
Contributor Author

WIN32 in cmake is just checking for Windows, including Win64 😅

I didn't even think to disable it on 32bit platforms yet :D

On Windows, ENV{CUDA_HOME} is not propagating as expected but if CMAKE_CUDA_PATH is set it works fine.

Thank you! Merging this

@galabovaa galabovaa merged commit 146aa59 into latest May 16, 2025
309 of 314 checks passed
@galabovaa galabovaa deleted the find-cuda-win branch June 23, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants