Simplify test-python CI workflow #2551
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #2551 +/- ##
==========================================
- Coverage 79.71% 79.70% -0.01%
==========================================
Files 346 346
Lines 86427 86427
==========================================
- Hits 68894 68889 -5
- Misses 17533 17538 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
odow
commented
Oct 1, 2025
odow
commented
Oct 1, 2025
.github/workflows/test-fortran.yml
Outdated
| version: 13 | ||
| - os: macos-13 | ||
| compiler: gcc | ||
| version: 11 |
Collaborator
Author
There was a problem hiding this comment.
Is it necessary to test this mix of compilers? Why 11 on Mac but 12 and 13 on linux?
odow
commented
Oct 1, 2025
| - os: ubuntu-latest | ||
| python: 3.11 | ||
| - os: windows-2022 | ||
| python: 3.12 |
Collaborator
Author
There was a problem hiding this comment.
Why 3.12 on Windows but 3.11 on Mac and linux?
odow
commented
Oct 1, 2025
odow
commented
Oct 1, 2025
Collaborator
Author
|
So @galabovaa, thoughts on simplifying some of the actions into a single file and using the build matrix? |
Contributor
|
As we discussed on our last Tuesday meeting, we will stick to development branches. Build matrix yes, single file not for a while |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR for @galabovaa to take a look at.
The current .github/workflows files are very verbose. We can use build strategies instead of separate files for every possible job. Here's a simple one.
If there is interest, I'd propose that we do the others.
Also: do we need to run jobs on every push and pull_request? We end up with stuff like #2518 where we're running 309 jobs!!! (Most of which are duplicates)
WIth this change, CI would run:
CI would not run:
This might be a downside, but it does nudge people to working in public PRs, rather than feature branches.
If we wanted to, we could add
- "ci-*"which would trigger CI if a branch was namedci-foo.