sanitizer tests#3025
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## hmw-mt #3025 +/- ##
=======================================
Coverage 72.71% 72.71%
=======================================
Files 426 426
Lines 103367 103367
Branches 16637 16637
=======================================
+ Hits 75159 75160 +1
+ Misses 27932 27931 -1
Partials 276 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Opt-Mucca
left a comment
There was a problem hiding this comment.
@galabovaa only one point (I do think that should be changed though).
Is enabling the sanitizers going to cause test times in general to now increase a lot?
We should just run it on PR, but until all is in latest I left it on push 😅 |
jajhall
left a comment
There was a problem hiding this comment.
Looks neater than before, so what's not to like!
|
@Opt-Mucca Is there a reason we have not merged this yet? |
@galabovaa I think I misinterpreted a comment and thought this would be merged with |
|
tbh that's what I thought at the time. can you please merge it? I see a conflict now with HStruct that you will know better about! |
std::vector is the one STL container with no element-independence guarantee