Skip to content

sanitizer tests#3025

Merged
Opt-Mucca merged 5 commits into
hmw-mtfrom
hmw-mt-san
Jun 21, 2026
Merged

sanitizer tests#3025
Opt-Mucca merged 5 commits into
hmw-mtfrom
hmw-mt-san

Conversation

@galabovaa

@galabovaa galabovaa commented May 15, 2026

Copy link
Copy Markdown
Contributor

std::vector is the one STL container with no element-independence guarantee

@galabovaa galabovaa requested review from Opt-Mucca and jajhall May 15, 2026 14:24
@codecov

codecov Bot commented May 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.71%. Comparing base (2ff03d5) to head (0d1d00b).

Additional details and impacted files
@@           Coverage Diff           @@
##           hmw-mt    #3025   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files         426      426           
  Lines      103367   103367           
  Branches    16637    16637           
=======================================
+ Hits        75159    75160    +1     
+ Misses      27932    27931    -1     
  Partials      276      276           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Opt-Mucca Opt-Mucca left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@galabovaa only one point (I do think that should be changed though).

Is enabling the sanitizers going to cause test times in general to now increase a lot?

Comment thread highs/lp_data/HStruct.h Outdated
@galabovaa

Copy link
Copy Markdown
Contributor Author

@galabovaa only one point (I do think that should be changed though).

Is enabling the sanitizers going to cause test times in general to now increase a lot?

We should just run it on PR, but until all is in latest I left it on push 😅

@jajhall jajhall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neater than before, so what's not to like!

@galabovaa

Copy link
Copy Markdown
Contributor Author

@Opt-Mucca Is there a reason we have not merged this yet?

@Opt-Mucca

Copy link
Copy Markdown
Collaborator

@Opt-Mucca Is there a reason we have not merged this yet?

@galabovaa I think I misinterpreted a comment and thought this would be merged with hmw-mt-mip-profile. This should be merged.

@galabovaa

Copy link
Copy Markdown
Contributor Author

tbh that's what I thought at the time. can you please merge it? I see a conflict now with HStruct that you will know better about!

@Opt-Mucca Opt-Mucca merged commit 1d8c083 into hmw-mt Jun 21, 2026
482 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants