Skip to content

Add reverse CI to test Uno with HiGHS and HiPO#3085

Merged
filikat merged 2 commits into
ERGO-Code:hipo-cfrom
amontoison:am/hipo-c
Jul 7, 2026
Merged

Add reverse CI to test Uno with HiGHS and HiPO#3085
filikat merged 2 commits into
ERGO-Code:hipo-cfrom
amontoison:am/hipo-c

Conversation

@amontoison

@amontoison amontoison commented Jun 23, 2026

Copy link
Copy Markdown

@galabovaa @filikat @cvanaret

I propose to merge this PR in the branch hipo-c and not latest.
I added a few comments to explain the current situation (branch hipo-c here and hipo in Uno) and what we want in the future.

Charlie, I only run the google tests for HiPOSolver but we can uncomment the Uno tests for HiGHSSolver once you fixed them.

I prefer that we add CI tests in an incremental way such that we can easily isolate the culprit if something is failing.

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (hipo-c@7363d01). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             hipo-c    #3085   +/-   ##
=========================================
  Coverage          ?   72.86%           
=========================================
  Files             ?      428           
  Lines             ?   102593           
  Branches          ?    16522           
=========================================
  Hits              ?    74750           
  Misses            ?    27567           
  Partials          ?      276           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@galabovaa galabovaa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you

@cvanaret

Copy link
Copy Markdown

Thanks Alexis!! I did a new Uno release with the HiGHS tests enabled :)

@filikat

filikat commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

@amontoison Is this ready to merge?

@amontoison

amontoison commented Jul 6, 2026

Copy link
Copy Markdown
Author

@cvanaret Sorry Charlie, I missed you message. I will update the PR.

@filikat I will update the PR today or tomorrow and it should be good to be merged.

@amontoison

amontoison commented Jul 6, 2026

Copy link
Copy Markdown
Author

@filikat If all builds are green, you can merge the PR 💪

@filikat

filikat commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

There is some issue while building Uno in the tests @amontoison

@amontoison

Copy link
Copy Markdown
Author

@filikat It should be fine now.

@filikat

filikat commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Ok, the Uno tests pass now.
Do you want to keep BUILD_SHARED_EXTRAS_LIB=ON in the workflow?
I have put back the dlclose in hipo-c, so the tests may fail that way.

@amontoison

Copy link
Copy Markdown
Author

@filikat I did a "matrix" to test both (BUILD_SHARED_EXTRAS_LIB=ON and BUILD_SHARED_EXTRAS_LIB=OFF) but be free to remove the case ON.

As long as we have a setup working for Uno, it is fine for us. 🙂

@filikat

filikat commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Ok, I will merge this and adjust the matrix if the tests fail.

@filikat filikat merged commit dd66745 into ERGO-Code:hipo-c Jul 7, 2026
462 of 463 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants