Add reverse CI to test Uno with HiGHS and HiPO#3085
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## hipo-c #3085 +/- ##
=========================================
Coverage ? 72.86%
=========================================
Files ? 428
Lines ? 102593
Branches ? 16522
=========================================
Hits ? 74750
Misses ? 27567
Partials ? 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
galabovaa
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you
|
Thanks Alexis!! I did a new Uno release with the HiGHS tests enabled :) |
|
@amontoison Is this ready to merge? |
|
@filikat If all builds are green, you can merge the PR 💪 |
|
There is some issue while building Uno in the tests @amontoison |
|
@filikat It should be fine now. |
|
Ok, the Uno tests pass now. |
|
@filikat I did a "matrix" to test both ( As long as we have a setup working for Uno, it is fine for us. 🙂 |
|
Ok, I will merge this and adjust the matrix if the tests fail. |
@galabovaa @filikat @cvanaret
I propose to merge this PR in the branch
hipo-cand notlatest.I added a few comments to explain the current situation (branch
hipo-chere andhipoin Uno) and what we want in the future.Charlie, I only run the google tests for
HiPOSolverbut we can uncomment the Uno tests forHiGHSSolveronce you fixed them.I prefer that we add CI tests in an incremental way such that we can easily isolate the culprit if something is failing.