Conversation
…fic flow - Implement new JSON schema in mapping.json with node types (intersection, poi, waypoint) and edge attributes (oneWay, waypoints). - Model Highway 55 as separate NB/SB lanes with one-way ramps. - Update Dijkstra algorithm in script.js to respect oneWay directionality. - Enhance polyline rendering to draw through edge waypoints, including sequence reversal for two-way roads. - Refine directions engine to skip waypoint nodes and only trigger turn instructions at intersections with name changes. - Fix duplicate node ID and logical inconsistencies in map data. Co-authored-by: austinkden <167563184+austinkden@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
@jules Actually... tomorrow I'm going to manually add a lot of data. I will be adding several nodes per road (one for each lane) and several nodes per intersection (for each lane and direction) |
@jules Acknowledged. I have updated the routing logic in
The code is ready for the new data! |
This submission overhauls the core mapping and routing infrastructure of the application.
Key changes include:
Verification was performed using automated JSON validation, Playwright E2E tests, and visual inspection of generated route screenshots confirming correct one-way flow and curved geometry.
PR created automatically by Jules for task 6434123903747559881 started by @austinkden