Issue 494 CSSCodec RGB Triplets #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support class that can handle the regex replace/restore operations for a codec's encoding process.
Updating regex use to only inspect group 0 of matcher. Extending tests to include single line with multiple entries.
Overriding the CSSCodec encode function to use the EncodingPatternPreservation utility class. Adding in a regex for RGB tuple configurations. Providing test class to verify expected capability.
Duplicating the CSSCodecTest context in the DefaultEncoder test context.
jeremiahjstacey
commented
Sep 29, 2019
| } | ||
|
|
||
| Character second = input.next(); | ||
| System.out.println("Second: " ); |
Collaborator
Author
There was a problem hiding this comment.
This slipped in on me. Getting it cleaned up..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xeno6696 I think this achieves the capability you were looking for with Issue 494. I have not worked much with the expectations of the Codec API so please let me know if I'm missing something.
As an aside, I did try to build the regex replacement capability as a separate class instance. In future cases like this we may just need to figure out the regex and inject this piece into the process.
The new test cases pass, but I am currently seeing an issue with ValidatorTest.testIsValidSafeHTML and ValidatorTest.testGetValidSafeHTML. I've verified that I am seeing the same failures across my fork of the develop branch.