cam6_4_112: Fix minor bugs in cloud chemistry

[mattldawson]

Several minor bugs related to cloud chemistry were identified during refactoring, and addressed here:

• different values for Henry's Law Constant parameters were being used for wet deposition and cloud chemistry
• air density was taken as an input to the cloud chemistry function setsox() and used in several places, but in other places air density is calculated assuming an ideal gas
• inconsistent and rounded values for physical constants (e.g., Avogadro's number, Boltzmann Constant, pressure unit conversion) are used in setsox()
• a hard-coded value of 330 ppm was used for CO2
• the rate of H2O2 formation was incorrectly calculated for bulk aerosols
• outdated rate parameters for sulfur oxidation were used
• there were errors in the filters used to prevent over-reaction of some sulfur oxidation reactions
• there were a couple missing diagnostics for bulk aerosol configurations
• there was some incorrect logic in the output of wet deposition diagnostics for CARMA

closes #1345

@fvitt @tilmes

[Copilot]

Pull Request Overview

This PR fixes several bugs in the cloud chemistry module that were identified during refactoring, improving consistency and accuracy in cloud chemistry calculations. The changes address issues with physical constants, Henry's Law constant parameters, sulfur oxidation rates, and diagnostic outputs.

• Unified Henry's Law constant parameters between wet deposition and cloud chemistry modules
• Replaced hard-coded physical constants with precise values and removed inconsistent air density inputs
• Updated sulfur oxidation rate parameters and reaction filters to prevent over-reaction

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/chemistry/aerosol/mo_setsox.F90	Major refactoring to use shared Henry's Law constants, precise physical constants, updated reaction rates, and corrected H2O2 formation calculation
src/chemistry/modal_aero/sox_cldaero_mod.F90	Fixed filtering logic to ensure all relevant species are bounded by small_value
src/chemistry/modal_aero/aero_model.F90	Removed air density parameter and added pbuf parameter to setsox call
src/chemistry/carma_aero/aero_model.F90	Removed air density parameter and added pbuf parameter to setsox call
src/chemistry/bulk_aero/aero_model.F90	Added missing diagnostics and updated setsox call signature
src/chemistry/aerosol/aero_wetdep_cam.F90	Fixed wet deposition diagnostic output logic
src/chemistry/aerosol/aero_convproc.F90	Corrected diagnostic field name for convective wet deposition
doc/ChangeLog	Documented the bug fixes and test results

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[cacraigucar]

I believe that @fvitt is the proper person to officially review this PR. But while I was skimming through it, I came across a couple of items which I believe should be addressed.

[fvitt]

My initial review.

[fvitt]

These lines should not be copied into the change log.

[mattldawson]

removed!

[fvitt]

I believe all of these baseline failures are expected -- configurations that include prognostic aerosols and aqueous chemistry.

[fvitt]

I believe the regression tests will be re-run and compared against the latest cam tag when this PR is ready to merge -- when @cacraigucar gives the go ahead to merge into cam_development and create the next tag. The test list may change and your new baselines may change after you merge to the head of cam_development.

[fvitt]

This date will need to be updated

[fvitt]

Looks good to me. Just need to update the ChangeLog when ready. Thanks.

[tilmes]

Budget changes for FCnudged MAM5 (1 year nudged simulation 2016):
Without bug fix:
SO4
Burden 0.385725
Aq.Production 12.079
Nucleation (not part of chem.prod) 0.186733
Chemical Prod. (extf) 0.329749
Chemical Prod. gaex 14.3837
Total Prod. 26.7927
Total Loss. 26.4659
Dry Deposition 3.16711
Wet Deposition -23.2988
Wet Deposition int -5.44412
Wet Deposition cloud -17.8537
Lifetime 5.31966

With bug fix:
SO4
Burden 0.364546
Aq.Production 12.7007
Nucleation (not part of chem.prod) 0.173515
Chemical Prod. (extf) 0.329755
Chemical Prod. gaex 13.3769
Total Prod. 26.4073
Total Loss. 26.2099
Dry Deposition 3.14111
Wet Deposition -23.0687
Wet Deposition int -5.59311
Wet Deposition cloud -17.4734
Lifetime 5.07669