cam6_3_029: Point CAM to the CARMA_base github repository instead of SVN repository#415
Conversation
|
Please modfiy the ChangeLog with preliminary information. Once the tests are run, then the testing section (and date) can be finalized prior to merge. |
… github repo instead of SVN repo.
cacraigucar
left a comment
cacraigucar
left a comment
There was a problem hiding this comment.
Once you fill in the couple of sections which I indicated should be filled in now, I will open this up to review by the larger group.
doc/ChangeLog
Outdated
|
|
||
| Describe any substantial timing or memory changes: | ||
|
|
||
| Code reviewed by: |
There was a problem hiding this comment.
This will need to be filled in after the reviews are complete with the people who did the review
doc/ChangeLog
Outdated
| @@ -1,4 +1,70 @@ | |||
| =============================================================== | |||
|
|
|||
| Tag name: | |||
There was a problem hiding this comment.
This will be filled in after the tag number is given to you
doc/ChangeLog
Outdated
| CAM tag used for the baseline comparison tests if different than previous | ||
| tag: | ||
|
|
||
| Summarize any changes to answers, i.e., | ||
| - what code configurations: | ||
| - what platforms/compilers: | ||
| - nature of change (roundoff; larger than roundoff but same climate; new | ||
| climate): | ||
|
|
||
| If bitwise differences were observed, how did you show they were no worse | ||
| than roundoff? | ||
|
|
||
| If this tag changes climate describe the run(s) done to evaluate the new | ||
| climate in enough detail that it(they) could be reproduced, i.e., | ||
| - source tag (all code used must be in the repository): | ||
| - platform/compilers: | ||
| - configure commandline: | ||
| - build-namelist command (or complete namelist): | ||
| - MSS location of output: | ||
|
|
||
| MSS location of control simulations used to validate new climate: | ||
|
|
||
| URL for AMWG diagnostics output used to validate new climate: |
There was a problem hiding this comment.
This section may be deleted if there are no answer changes (which is what I expect with this tag you are making) This should wait until you've run all the tests to confirm there are no answer changes.
doc/ChangeLog
Outdated
|
|
||
| Tag name: | ||
| Originator(s):mlander | ||
| Date:11 Aug 2021 |
There was a problem hiding this comment.
The date will need to be changed to the date you actually do the merge
cacraigucar
left a comment
cacraigucar
left a comment
There was a problem hiding this comment.
Please change the number for the issue and I'll issue my approval and then request the full review.
doc/ChangeLog
Outdated
| - replaced the following lines (lines 10 & 11) | ||
| protocol = svn | ||
| repo_url = https://svn-ccsm-models.cgd.ucar.edu/carma/release_tags | ||
| with | ||
| protocol = git | ||
| repo_url = https://github.com/ESCOMP/CARMA_base.git |
There was a problem hiding this comment.
@manderberg - This is fine, but probably more detail than we usually put in the ChangeLog. If you were making a change with dozens of changed lines, you will just summarize why the changes were made. A one line "Change external for CARMA to git from svn" would be sufficient. You don't need to change this. One way to look at the ChangeLog as being an index to the changes. Someone can browse through the file it to find when a change may have been made and then they can use a tool to actually investigate the actual differences.
cacraigucar
requested review from
cacraigucar,
fvitt,
gold2718,
nusbaume and
peverwhee
fvitt
left a comment
fvitt
left a comment
There was a problem hiding this comment.
Looks good to me.
Thanks.
nusbaume
left a comment
nusbaume
left a comment
There was a problem hiding this comment.
The code changes look good to me! However, can you add the text:
Fixes #414
Into the top-level text box of this PR (i.e. the one you wrote when you first opened the PR)? That way the issue will be closed automatically once the changes are merged, and it allows some of our scripts to keep track of the status of various projects, branches, etc. Thanks!
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
Just need to fill in and push the ChangeLog header info before merging.
cacraigucar
changed the title
cacraigucar
changed the title
6 participants
Edited the file Externals_CAM.cfg to point CAM to the CARMA_base github repository instead of the SVN repository.
[carma]
-local_path = src/physics/carma/base
-protocol = svn
-repo_url = https://svn-ccsm-models.cgd.ucar.edu/carma/release_tags
-tag = carma3_49_rel
+local_path = src/physics/carma/base
+protocol = git
+repo_url = https://github.com/ESCOMP/CARMA_base.git
+tag = carma3_49
required = True
Fixes #414