replace calls to esmf_logmsg_error with shr_abort#320
Merged
jedwards4b merged 6 commits intoESCOMP:mainfrom Jan 24, 2025
Merged
replace calls to esmf_logmsg_error with shr_abort#320jedwards4b merged 6 commits intoESCOMP:mainfrom
jedwards4b merged 6 commits intoESCOMP:mainfrom
Conversation
Collaborator
|
@jedwards4b I think needs a cesm_share update (?). Is that in a branch somewhere (apologies if I'm mixed up---lots of balls in the air). |
Contributor
Author
|
The cesm_share code is copied into the share directory of cdeps for you. |
Contributor
Author
|
@DeniseWorthen the share code that you need is in the share directory of this repo. |
Collaborator
|
I needed to add a use statement here to get it to compile: |
Contributor
Author
|
Good catch, thank you. |
DeniseWorthen
approved these changes
Jan 24, 2025
Collaborator
DeniseWorthen
left a comment
There was a problem hiding this comment.
Works in UFS. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Replace calls to esmf_logwrite which are abort messages with calls to shr_sys_abort which now includes the esmf_logwrite call.
Specific notes
Contributors other than yourself, if any:
CDEPS Issues Fixed (include github issue #):
Are there dependencies on other component PRs (if so list):
Are changes expected to change answers (bfb, different to roundoff, more substantial):
Any User Interface Changes (namelist or namelist defaults changes):
Testing performed (e.g. aux_cdeps, CESM prealpha, etc):
Hashes used for testing: