Skip to content

fix temp arg created#643

Merged
billsacks merged 1 commit intoESCOMP:mainfrom
ACCESS-NRI:debug_failures
Apr 15, 2026
Merged

fix temp arg created#643
billsacks merged 1 commit intoESCOMP:mainfrom
ACCESS-NRI:debug_failures

Conversation

@anton-seaice
Copy link
Copy Markdown
Contributor

@anton-seaice anton-seaice commented Apr 1, 2026

Description of changes

Fixes an error when building with -check all

forrtl: warning (406): fort: (1): In call to MED_IO_WRITE_TIME, an array temporary was created for argument #3

Testing performed

Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing

Copy link
Copy Markdown
Member

@billsacks billsacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix looks good to me - thank you!

Since this is still marked draft, I'm assuming that there's still some more work / testing you want to do? Before we merge, it would be good to see that at least a little testing has been done on this change.

@anton-seaice
Copy link
Copy Markdown
Contributor Author

Thanks @billsacks

Indeed - I needed to get back to this and run some tests.

I've confirmed this now builds with -check all ok.

I've confirmed the normal Release build has no change in answers - I ran this is a couple of configs, and tests for reproducibility against old results and over restarts.

In the cpl.r file, time_bnds appear fine - both the upper and lower bound equal the time variable.

@anton-seaice anton-seaice marked this pull request as ready for review April 14, 2026 01:29
@anton-seaice
Copy link
Copy Markdown
Contributor Author

Please merge if you are happy !

@billsacks billsacks merged commit 7750ad8 into ESCOMP:main Apr 15, 2026
1 of 7 checks passed
anton-seaice added a commit to ACCESS-NRI/CMEPS that referenced this pull request Apr 16, 2026
This applies ESCOMP#643 to the ACCESS fork
@anton-seaice anton-seaice deleted the debug_failures branch April 16, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants