generate_gdds: Work on arguments#3729
Merged
samsrabin merged 10 commits intoESCOMP:b4b-devfrom Feb 4, 2026
Merged
Conversation
…h-from-hdates-file.
…max-season-length-from-hdates-file.
slevis-lmwg
approved these changes
Feb 3, 2026
Contributor
slevis-lmwg
left a comment
There was a problem hiding this comment.
@samsrabin gave me a detailed tour of the PR. We discussed a couple of questions that I had along the way. I did not see showstoppers, so I'm approving.
One of the arguments --paramfile --max-season-length-from-hdates-file is required. For simplicity (not having to figure out what the paramfile for the run was) I chose the latter.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Various additions to arguments of
generate_gdds.py. Adds capability but shouldn't change default answers.--unlimited-season-lengthto--max-season-length-from-hdates-fileto more accurately reflect what it does.--paramfileargument, which is required when the above is not provided, because if not getting max season length from harvest dates file it'll come from a paramfile. (Mutually exclusive with the above.)Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? Yes; no. Will come in once #3319 is done.
Testing performed, if any:
Tested as part of my crop reparameterization work.
clm_pymodstest suiterxcropmaturitytest suite