Skip to content

generate_gdds: Work on arguments#3729

Merged
samsrabin merged 10 commits intoESCOMP:b4b-devfrom
samsrabin:generate_gdds-args-work
Feb 4, 2026
Merged

generate_gdds: Work on arguments#3729
samsrabin merged 10 commits intoESCOMP:b4b-devfrom
samsrabin:generate_gdds-args-work

Conversation

@samsrabin
Copy link
Member

@samsrabin samsrabin commented Jan 30, 2026

Description of changes

Various additions to arguments of generate_gdds.py. Adds capability but shouldn't change default answers.

  • Adds argument testing.
  • Renames --unlimited-season-length to --max-season-length-from-hdates-file to more accurately reflect what it does.
  • Adds --paramfile argument, which is required when the above is not provided, because if not getting max season length from harvest dates file it'll come from a paramfile. (Mutually exclusive with the above.)
  • Refactors and tests code for getting max season length.
  • Fail if provided sowing and harvest date files don't match the CLM grid.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? Yes; no. Will come in once #3319 is done.

Testing performed, if any:
Tested as part of my crop reparameterization work.

  • Python unit testing
  • Python system testing
  • clm_pymods test suite
  • rxcropmaturity test suite

@samsrabin samsrabin self-assigned this Jan 30, 2026
@samsrabin samsrabin added enhancement new capability or improved behavior of existing capability bfb bit-for-bit PR status: awaiting review Work on this PR is paused while waiting for review. PR status: needs testing test: python Pass clm_pymods test suite plus Python sys/unit tests before merging labels Jan 30, 2026
@samsrabin samsrabin moved this to In progress - b4b-dev in CTSM: Upcoming tags Feb 2, 2026
Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samsrabin gave me a detailed tour of the PR. We discussed a couple of questions that I had along the way. I did not see showstoppers, so I'm approving.

@github-project-automation github-project-automation bot moved this from In progress - b4b-dev to In progress - master in CTSM: Upcoming tags Feb 3, 2026
@samsrabin samsrabin moved this from In progress - master to In progress - b4b-dev in CTSM: Upcoming tags Feb 4, 2026
@samsrabin samsrabin removed the PR status: awaiting review Work on this PR is paused while waiting for review. label Feb 4, 2026
One of the arguments --paramfile --max-season-length-from-hdates-file is required. For simplicity (not having to figure out what the paramfile for the run was) I chose the latter.
@samsrabin samsrabin merged commit 56bfaff into ESCOMP:b4b-dev Feb 4, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from In progress - b4b-dev to Done (non release/external) in CTSM: Upcoming tags Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bfb bit-for-bit enhancement new capability or improved behavior of existing capability PR status: needs testing test: python Pass clm_pymods test suite plus Python sys/unit tests before merging

Projects

Status: Done (non release/external)

Development

Successfully merging this pull request may close these issues.

2 participants