Skip to content

Update PR template#3986

Merged
samsrabin merged 9 commits into
ESCOMP:b4b-devfrom
samsrabin:update-pr-template-20260501
May 4, 2026
Merged

Update PR template#3986
samsrabin merged 9 commits into
ESCOMP:b4b-devfrom
samsrabin:update-pr-template-20260501

Conversation

@samsrabin
Copy link
Copy Markdown
Member

Description of changes

  • Adds list of checkboxes for things required before merge.
  • Adds comments with instructions.
  • Does some reformatting.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed (include github issue #): None

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: None

@samsrabin samsrabin self-assigned this May 1, 2026
@samsrabin samsrabin added next this should get some attention in the next week or two. Normally each Thursday SE meeting. b4b bit-for-bit size: small devops Development Operations to improve development throughput, E.g., adding GitHub Workflows labels May 1, 2026
@samsrabin samsrabin force-pushed the update-pr-template-20260501 branch from c836770 to 1b053d7 Compare May 1, 2026 18:05
@samsrabin samsrabin force-pushed the update-pr-template-20260501 branch from 1b053d7 to 3794497 Compare May 1, 2026 18:08
@samsrabin samsrabin requested a review from wwieder May 4, 2026 16:48
Copy link
Copy Markdown
Contributor

@wwieder wwieder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these improvements. I flagged one suggested bit of extra text that could be removed, but otherwise I approve

Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
Copy link
Copy Markdown
Contributor

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I just added a suggestion to say to put issues resolved one per line with "Fixed" in front ot it. Doing this allows them to autoclose. And I added some suggestions about the answer changing section and the testing part.

Comment thread .github/PULL_REQUEST_TEMPLATE.md
Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
@samsrabin samsrabin removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label May 4, 2026
@samsrabin samsrabin merged commit 79b71c1 into ESCOMP:b4b-dev May 4, 2026
9 checks passed
@slevis-lmwg slevis-lmwg mentioned this pull request May 7, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b4b bit-for-bit devops Development Operations to improve development throughput, E.g., adding GitHub Workflows size: small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants