Fix combining of partitioned netcdf files for overriden history files#6
Merged
Merged
Conversation
jedwards4b
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
new_file_freqof a history stream is more frequent than the most frequent datestamp suffix in filename (e.g.,'daily'and'%2mo'), that files gets overriden (~30 times over a month), meaning that it gets closed multiple times. With this PR, a file gets appended tofilepath_list(the linked list of files to combine) only once even if it gets closed (overriden) multipe times.Note for @mnlevy1981 : This edge case was caught in aux_mom MARBL tests because the
dailybgcfiles do not have the day stamp in the file name.