Skip to content

Add new parameter defaults for beta06 and fixes typo in diag_table#252

Merged
alperaltuntas merged 9 commits intoESCOMP:mainfrom
gustavo-marques:add_params_075
Apr 28, 2025
Merged

Add new parameter defaults for beta06 and fixes typo in diag_table#252
alperaltuntas merged 9 commits intoESCOMP:mainfrom
gustavo-marques:add_params_075

Conversation

@gustavo-marques
Copy link
Copy Markdown
Collaborator

  • Include the parameters used in 2025.075 as default;
  • Fixes typos in the min/max variables for mlotst.

Addresses #247 and #251.

@gustavo-marques gustavo-marques marked this pull request as ready for review April 23, 2025 20:00
@alperaltuntas
Copy link
Copy Markdown
Member

Failures encountered so far:

  • Dimensional scaling fails for L and Z dimensions
  • Exact reproducibility tests fail.
  • Regression tests fail (expected).

@alperaltuntas
Copy link
Copy Markdown
Member

I narrowed down the problem to USE_CR_GRID. Setting it to False seems to fix the first two failures above.

@gustavo-marques
Copy link
Copy Markdown
Collaborator Author

Thanks for tracking this down!
Maybe we need to add scale=1. in this call to MOM_read_data.

Previous version contained incorrect values; this update fixes them.
@alperaltuntas alperaltuntas merged commit fb5ce02 into ESCOMP:main Apr 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants