Add tx2_3v3, following tx2_3v2#318
Conversation
|
Converting it to a draft until files are imported and PR is tested. |
|
@mnlevy1981, did you have a chance to add the files here to the input data? @alperaltuntas, once Mike confirms that the files have been imported, this PR will be ready for review. |
mnlevy1981
left a comment
There was a problem hiding this comment.
I see 8 files that are added to both input_data_list.yaml and MOM_input.yaml:
ocn/mom/tx2_3v3/channels_tx2_3v3_260304.txt
ocn/mom/tx2_3v3/geothermal_davies2013_tx2_3v3_260305.nc
ocn/mom/tx2_3v3/mle_cr_labsea_mask_tx2_3v3_260306.nc
ocn/mom/tx2_3v3/ocean_hgrid_250930.nc
ocn/mom/tx2_3v3/ocean_topo_tx2_3v3_260305.nc
ocn/mom/tx2_3v3/seawifs-clim-1997-2010-tx2_3v3_260305.nc
ocn/mom/tx2_3v3/state_restore_tx2_3v3_260305.nc
ocn/mom/tx2_3v3/tidal_energy_tx2_3v3_conserve_260306.nc
I have added those files to the inputdata repository. However, these two are in MOM_input.yaml but not input_data_list.yaml (and also don't exist in the inputdata directory on derecho):
ocn/mom/tx2_3v3/lev-2025-09-12.nc
ocn/mom/tx2_3v3/dz_max-2025-09-12.nc
I don't think the tx2_3v2 versions have been added to the inputdata repository and we haven't caught that because they are not in input_data_list.yaml either. I suggest we import the tx2_3v2 versions and also add them to input_data_list.yaml; we can decide if we want separate tx2_3v3 copies or not separately.
| $MOM6_VERTICAL_GRID == "hycom1" and $OCN_GRID in ["tx2_3v3"]: | | ||
| '"FILE:${DIN_LOC_ROOT}/ocn/mom/tx2_3v3/lev-2025-09-12.nc,Z"' |
There was a problem hiding this comment.
This file does not exist in campaign; should we just use the tx2_3v2 version? If so, you should modify the two lines above these:
- $MOM6_VERTICAL_GRID == "hycom1" and $OCN_GRID in ["tx2_3v2"]: |
+ $MOM6_VERTICAL_GRID == "hycom1" and $OCN_GRID in ["tx2_3v2", "tx2_3v3"]: |
'"FILE:${DIN_LOC_ROOT}/ocn/mom/tx2_3v2/lev-2025-09-12.nc,Z"'| $MOM6_VERTICAL_GRID == "hycom1" and $OCN_GRID in ["tx2_3v3"]: | | ||
| '"FILE:${DIN_LOC_ROOT}/ocn/mom/tx2_3v3/dz_max-2025-09-12.nc,dz"' |
There was a problem hiding this comment.
Same as previous comment, this file doesn't exist on campaign. If you want to use the tx2_3v2 version of this file, then update the logic around tx2_3v2 default to be $MOM6_VERTICAL_GRID == "hycom1" and $OCN_GRID in ["tx2_3v2", "tx2_3v3"]
|
Thanks, @mnlevy1981. Both
I see the two files in input_data_list.yaml (see here). I am not sure if adding the following is what we need here: |
|
Running the |
|
2bde1c4 updated the YAML file but not the JSON file, resulting in I imported the two |
Add tx2_3v3, following tx2_3v2. New parameter settings for tx2_3v3 will be included in an upcoming PR.