Add travis-ci tests with python3.7 and python3.8, and fix python3 pylint error #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis-ci tests with python3 were failing with: ************* Module manic.repository_svn R1724:221,12: Unnecessary "else" after "continue" (no-else-continue) This should fix the problem. (I'm not sure why this started failing now: this is old code. Maybe pylint recently was updated to add this check?)
billsacks
changed the title
Member
Author
|
I'm actually going to close this PR and open a separate one that fixes #135 . My point in opening this PR was to add python3.8 tests, but actually I can do that and fix them all at once. For the record, though, note that 3.8 tests do indeed fail in this baseline: https://travis-ci.org/ESMCI/manage_externals/builds/657489403?utm_source=github_status&utm_medium=notification For some reason the travis-ci MacOS tests are also failing now. We might want to just remove them: note that the way we're doing MacOS tests with travis-ci is a bit wonky. |
This is failing. It's using python2, which is no longer supported (though I don't know if that's why it's failing). I don't see the point in trying to update it to use python3, since I feel we have sufficient coverage with our linux testing, so for now I'm just removing it.
Trying to update the dictionary in-place in the loop leads to an error
in python 3.8 ("dictionary keys changed during iteration"). Instead,
create a copy of the dictionary, modified as needed.
Resolves ESMCI#135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by #135
User interface changes?: No
Fixes: None
Testing: Just travis-ci
test removed: none
unit tests:
system tests:
manual testing: