On checkout, refresh locally installed optional components regardless of whether -o is passed in. #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aths and path components within an _External. Also: Rename ‘externals’ variables to better reveal their type, e.g. externals_path, ext_description. s/model/ext_description/ for consistency. Clarify that _External has its own sourcetree for subcomponents. Add a __repr__ to ExternalStatus for convenience.
…f whether -o is passed in.
Implementation detail: this involves checking external’s status. But since Sourcetree.status() and therefore _External.status() is already called at the very start of checkout_externals, allow it to be efficiently called twice:
Change _External.status() to skip doing work if it was run before.
Make it optional to print out the external names as it does its work.
Also:
sourcetree.py: no longer assumes status() is called before checkout() - checks self._stat and calls status() if needed.
checkout.py: move enormous message into its own helper function
jedwards4b
approved these changes
Jan 4, 2023
This was referenced Jan 6, 2023
johnpaulalex
added a commit
to johnpaulalex/manage_externals_jp
that referenced
this pull request
Jan 9, 2023
Finding locally installed optional components was broken both because it did not correctly inspect the status of those components, and because it added components-to-checkout by path instead of by name. Printing status updates also a bit wonky because 'print_progress' was not correctly passed down. Slight update to testing docs: no need to run python 2 and 3 separately, and system tests now exist.
johnpaulalex
added a commit
to johnpaulalex/manage_externals_jp
that referenced
this pull request
Jan 9, 2023
Finding locally installed optional components was broken both because it did not correctly inspect the status of those components, and because it added components-to-checkout by path instead of by name. Printing status updates also a bit wonky because 'print_progress' was not correctly passed down. Slight update to testing docs: no need to run python 2 and 3 separately, and system tests now exist.
jedwards4b
added a commit
that referenced
this pull request
Jan 9, 2023
Fix broken checkout behavior introduced by PR #172.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(note this CL is on top of the 'docstatus' branch aka pull request #171, I hope I did that right)
Implementation detail: this involves checking external’s status. But since Sourcetree.status() and therefore
_External.status() is already called at the very start of checkout_externals, allow it to be efficiently called twice:
Change _External.status() to skip doing work if it was run before.
Make it optional to print out the external names as it does its work.
Also:
sourcetree.py: no longer assumes status() is called before checkout() - checks self._stat and calls status() if needed.
checkout.py: move enormous message into its own helper function
User interface changes?: Yes - checkout now refreshes any local optional components regardless of -o flag.
Fixes: Github issue #155
Testing:
test removed:
unit tests:
system tests:
manual testing: ran with specific component and with no components as arguments.