Fix broken checkout behavior introduced by PR #172. #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finding locally installed optional components was broken both because it did not correctly inspect the status of those components, and because it added components-to-checkout by path instead of by name. Printing status updates also a bit wonky because 'print_progress' was not correctly passed down. Slight update to testing docs: no need to run python 2 and 3 separately, and system tests now exist.
jedwards4b
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finding locally installed optional components (for the case of running checkout_externals without -o and/or without specific component names) was broken both because it did not correctly inspect the status of those components, and because it added components-to-checkout by path instead of by name. (and that got in because my manual testing method was flawed)
Printing status updates was also a bit wonky because 'print_progress' was not correctly passed down.
Slight update to testing docs: no need to run python 2 and 3 separately, and system tests now exist.
User interface changes?: No
Fixes: Issue #174 (but does not add an additional automated test for the new behavior, that is coming next)
Testing:
test removed:
unit tests: passed
system tests: passed
manual testing: Ran checkout_externals all the way through, verified that its list of locally installed optional components was correct, and correctly passed on to the actual checkout code.