Skip to content

6 python structure#11

Merged
rogerkuou merged 14 commits into
mainfrom
6_python_structure
Jan 28, 2026
Merged

6 python structure#11
rogerkuou merged 14 commits into
mainfrom
6_python_structure

Conversation

@rogerkuou
Copy link
Copy Markdown
Collaborator

@rogerkuou rogerkuou commented Jan 26, 2026

Partially work on #6

  • github workflows
  • readme and badges
  • pyproject.toml
  • docs
  • src
  • setup main branch protection
  • citation.cff
  • pre-commit hook: as dev dependency and config file
  • rename the repo
  • add a logo (optional)
  • pypi and zenodo account (check who from project partners can be the admin)

@rogerkuou rogerkuou marked this pull request as ready for review January 26, 2026 15:27
@rogerkuou rogerkuou marked this pull request as draft January 26, 2026 15:28
@rogerkuou rogerkuou marked this pull request as ready for review January 26, 2026 15:47
@rogerkuou
Copy link
Copy Markdown
Collaborator Author

Hi @SarahAlidoost and @meiertgrootes, I added the Python structure as much as we can. Can you give it a look?

I plan to leave the unfished tasked uncheck in #6, and fix them in another PR.

For the name of this workflow, maybe you can give some suggestions? I will do the logo together with it.
For PyPI and zenodo account, is the idea that we should ask someone else to own it?

Comment thread .github/build.yml Outdated
Comment thread CITATION.cff
family-names: Ku
affiliation: Netherlands eScience Center
email: o.ku@esciencecenter.nl
orcid: 'https://orcid.org/0000-0002-5373-5209'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add Bouwe to the list.

Comment thread pyproject.toml Outdated
Comment thread pyproject.toml
@SarahAlidoost
Copy link
Copy Markdown
Member

SarahAlidoost commented Jan 28, 2026

Hi @SarahAlidoost and @meiertgrootes, I added the Python structure as much as we can. Can you give it a look?

Thanks! 👍

For the name of this workflow, maybe you can give some suggestions? I will do the logo together with it.

For PyPI and zenodo account, is the idea that we should ask someone else to own it?

@bouweandela can you help with this, how is this done in esmvalgroup?

Copy link
Copy Markdown
Member

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogerkuou looks good! thanks 👍 just a few comments, then feel free to merge it.

Copy link
Copy Markdown
Collaborator

@meiertgrootes meiertgrootes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have nothing to add to @SarahAlidoost 's comments.

rogerkuou and others added 4 commits January 28, 2026 12:44
@rogerkuou
Copy link
Copy Markdown
Collaborator Author

Thanks @SarahAlidoost and @meiertgrootes. I adapted all of Sarah's comments. And added one more thing: the precommit hook config file, where I called ruff for linting and formatting. Will merge this now. The issue still remains open until we finish the rest items.

@rogerkuou rogerkuou merged commit 9103417 into main Jan 28, 2026
@rogerkuou rogerkuou deleted the 6_python_structure branch January 28, 2026 12:10
@bouweandela
Copy link
Copy Markdown
Member

For PyPI and zenodo account, is the idea that we should ask someone else to own it?

@bouweandela can you help with this, how is this done in esmvalgroup?

For PyPI, we have an ESMValGroup organization and use trusted publishing. If you feel it would be useful to publish the package to PyPI, I can create the project (once you have decided on a name) and set up trusted publishing for you.

For Zenodo: for the other repositories we have a few owners, but maybe we could create an ESMValGroup community. Do you have experience with these? Would that allow editing metadata of the records?

meiertgrootes pushed a commit that referenced this pull request May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants