6 python structure#11
Conversation
|
Hi @SarahAlidoost and @meiertgrootes, I added the Python structure as much as we can. Can you give it a look? I plan to leave the unfished tasked uncheck in #6, and fix them in another PR. For the name of this workflow, maybe you can give some suggestions? I will do the logo together with it. |
| family-names: Ku | ||
| affiliation: Netherlands eScience Center | ||
| email: o.ku@esciencecenter.nl | ||
| orcid: 'https://orcid.org/0000-0002-5373-5209' |
There was a problem hiding this comment.
please also add Bouwe to the list.
Thanks! 👍
@bouweandela can you help with this, how is this done in esmvalgroup? |
SarahAlidoost
left a comment
There was a problem hiding this comment.
@rogerkuou looks good! thanks 👍 just a few comments, then feel free to merge it.
meiertgrootes
left a comment
There was a problem hiding this comment.
Looks good. I have nothing to add to @SarahAlidoost 's comments.
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
|
Thanks @SarahAlidoost and @meiertgrootes. I adapted all of Sarah's comments. And added one more thing: the precommit hook config file, where I called ruff for linting and formatting. Will merge this now. The issue still remains open until we finish the rest items. |
For PyPI, we have an ESMValGroup organization and use trusted publishing. If you feel it would be useful to publish the package to PyPI, I can create the project (once you have decided on a name) and set up trusted publishing for you. For Zenodo: for the other repositories we have a few owners, but maybe we could create an ESMValGroup community. Do you have experience with these? Would that allow editing metadata of the records? |
Partially work on #6