Add parentheses, remove unused variables, replace abs by fabs#2
Merged
Conversation
The abs function computes the absolute value of an integer only. Replace abs by fabs to calculate the absolute value of a double.
The && operator has higher precedance than the || operator. Therefore, this commit doesn't change the behavior of the code. However, this commit makes the code easier to understand and it prevents some compiler warnings (-Wparentheses with gcc).
edisongustavo
approved these changes
Nov 23, 2016
Contributor
edisongustavo
left a comment
edisongustavo
left a comment
There was a problem hiding this comment.
Thanks for the PR.
You're correct that the usage of abs() is error-prone.
I agree that using fabs() is safer and not error prone (like abs()).
It is not wrong at the actual state since abs() is overloaded for double types at math.h. So it is not currently a bug.
It is a healthy improvement to the code nonetheless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes three changes: