Fix access on uninitialized memory#6
Merged
Conversation
The original Fortran code looks like (see http://www.netlib.org/cgi-bin/netlibfiles.txt?format=txt&filename=quadpack%2Fdqawo.f) numrl2 = 0 extall = .false. if(0.5d+00*dabs(b-a)*domega.gt.0.2d+01) go to 10 numrl2 = 1 For this reason the C code should look like numrl2 = -1; ... numrl2 = 0; After this patch LLVM no longer complains about uninitialized access on memory.
Contributor
|
Seem very reasonable. I compared both codes and this is a correct fix. Thanks! (I wonder how people wrote the original fortran code. It is practically unreadable) |
Contributor
Author
|
The original Fortran Code is hardly readable... :( By the way, does the test suite cover all cquadpack functions? |
Contributor
I don't know, I've just put the available tests there. |
Contributor
Author
|
Ok. I've compiled all available tests with clang and activaded the memory sanitzer which checks for access of uninitialized memory. So, at least the functions that are called by the tests should be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original Fortran code looks like (see
http://www.netlib.org/cgi-bin/netlibfiles.txt?format=txt&filename=quadpack%2Fdqawo.f)
For this reason the C code should look like
numrl2 = -1;
...
numrl2 = 0;
After this patch LLVM no longer complains about uninitialized access on memory.