Fix mp_hal_stdout_tx_strn(): use ssize_t, loop for partial writes, handle EINTR#4
Merged
morita5840 merged 2 commits intofix/mphal-stdout-tx-strn-signaturefrom Mar 21, 2026
Conversation
…ndle EINTR Co-authored-by: morita5840 <27051616+morita5840@users.noreply.github.com> Agent-Logs-Url: https://github.com/ETrobocon/pybricks-micropython/sessions/47be6172-8e95-4d8b-bd62-96efebdf1c34
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on signature mismatch in mp_hal_stdout_tx_strn() fix
Fix mp_hal_stdout_tx_strn(): use ssize_t, loop for partial writes, handle EINTR
Mar 21, 2026
morita5840
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write()returnsssize_t, but the result was stored inintand returned asmp_uint_t, causing silent truncation of large write counts on 64-bit systems. There was also no handling of partial writes orEINTR, meaning stdout output could be silently dropped.Changes
bricks/ev3dev/ev3dev_mphal.crettype frominttossize_tstrpointer on partial writesEINTR; return bytes written so far on other errorsret > remainingto prevent unsigned underflow (POSIX-impossible, but explicit)⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.