Fix validate_yaml double extension and string time coordinates#57
Closed
bjarketol wants to merge 2 commits intoEUFLOW:mainfrom
Closed
Fix validate_yaml double extension and string time coordinates#57bjarketol wants to merge 2 commits intoEUFLOW:mainfrom
bjarketol wants to merge 2 commits intoEUFLOW:mainfrom
Conversation
- Pass schema key "plant/wind_energy_system" to validate_yaml instead of constructing a full file path, which caused a .yaml.yaml double extension - Convert string/datetime time coordinates to integer indices in dict_to_site() so PyWake's GridInterpolator can interpolate numerically - Relax xarray version constraint (remove upper bound <2025) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
@kilojoules can you review this? |
Contributor
Author
|
Will be fixed in #58 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_yamlcall inrun_api()to pass schema key"plant/wind_energy_system"instead of constructing a full file path, which caused a.yaml.yamldouble extension errordict_to_site()so PyWake'sGridInterpolatorcan interpolate numerically<2025upper bound)🤖 Generated with Claude Code