Remove bool return type from SLAC API#1461
Merged
Merged
Conversation
Pietfried
requested review from
SebaLukas,
a-w50,
andistorm,
corneliusclaussen,
hikinggrass,
james-ctc and
mlitre
as code owners
Contributor
Author
|
@james-ctc I had to adjust the interface hash file because of the respective changes to the interface. Ready for re-review. |
james-ctc
approved these changes
Oct 27, 2025
hikinggrass
approved these changes
Oct 27, 2025
…the interface. Commands are not expected to fail, and any failure cannot be handled in a meaningful or recoverable way. Removing the return values clarifies the intent and simplifies the API. Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>
Pietfried
force-pushed
the
refactor/remove-return-slac-api
branch
from
b45eeed to
cb98ce2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Remove return types of slac API commands to simplify the interface.
The affected commands are
These commands are not expected to fail, and any failure cannot be handled in a meaningful or recoverable way. Removing the return values clarifies the intent and simplifies the API.
Issue ticket number and link
Checklist before requesting a review