fix: framework: store retain flag of messages published before connected#1798
Merged
Conversation
…cted If this flag is not stored the retained flag is accidentally dropped which can lead to issues further down the line This mostly would be an issue in the framework manager which publishes a few topics on startup such as everest/interfaces which must be retained for modules to receive their payload later. If the flag is not set the module would try to get() this data only to timeout with a "Timeout while waiting for result of get()" error message, terminating the startup of the module Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
hikinggrass
requested review from
Pietfried,
SebaLukas and
corneliusclaussen
as code owners
hikinggrass
requested review from
cburandt,
djchhp,
florinmihut and
james-ctc
as code owners
Pietfried
approved these changes
Feb 12, 2026
Dalachowsky
pushed a commit
to Dalachowsky/everest-core
that referenced
this pull request
Feb 20, 2026
…cted (EVerest#1798) If this flag is not stored the retained flag is accidentally dropped which can lead to issues further down the line This mostly would be an issue in the framework manager which publishes a few topics on startup such as everest/interfaces which must be retained for modules to receive their payload later. If the flag is not set the module would try to get() this data only to timeout with a "Timeout while waiting for result of get()" error message, terminating the startup of the module Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
If this flag is not stored the retained flag is accidentally dropped which can lead to issues further down the line
This mostly would be an issue in the framework manager which publishes a few topics on startup such as everest/interfaces which must be retained for modules to receive their payload later. If the flag is not set the module would try to get() this data only to timeout with a "Timeout while waiting for result of get()" error message, terminating the startup of the module
Issue ticket number and link
Checklist before requesting a review