Skip to content

Fix compiler warnings in generated c code.#81

Merged
SebaLukas merged 1 commit intoEVerest:mainfrom
ashesman:fixCompilerWarnings
Oct 10, 2024
Merged

Fix compiler warnings in generated c code.#81
SebaLukas merged 1 commit intoEVerest:mainfrom
ashesman:fixCompilerWarnings

Conversation

@ashesman
Copy link
Contributor

Describe your changes

  • Fixed const cast compiler warnings in generated C code
  • exi_basetypes_encoder.c const cast warnings
  • appHand_Decoder.c and appHandEncoder.c missing header file includes (function with no prototype warning)
  • exi_bitstream.h added struct name to exibitstream_t type so can be used in c++

Issue ticket number and link

EVerest/libcbv2g#16 (review)

Checklist before requesting a review

  • [Y ] I have performed a self-review of my code
  • [ -] I have made corresponding changes to the documentation
  • [ Y] I read the contribution documentation and made sure that my changes meet its requirements

Copy link
Member

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi :) please add a signed-off-by trailer in your commit message. LFE projects require this signed-off-by. Have a look here: https://git-scm.com/docs/git-commit#Documentation/git-commit.txt--s

Signed-off-by: Ashley <ashes.man@gmail.com>
Copy link
Member

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SebaLukas SebaLukas merged commit 90c70d0 into EVerest:main Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants