Conversation
Signed-off-by: Moritz Barsnick <moritz.barsnick@chargebyte.com>
Signed-off-by: Moritz Barsnick <moritz.barsnick@chargebyte.com>
This was referenced Nov 18, 2024
SebaLukas
reviewed
Nov 19, 2024
Member
SebaLukas
left a comment
SebaLukas
left a comment
There was a problem hiding this comment.
It looks good to me!
I will test this in the next few days with libcbv2g and EVerest SIL.
Member
|
A |
When expanding "abstract sequences" (actually choices implied by abstraction and derivation), the new choice list was accidentally added, even if one already existed, instead of expanding the existing one(s). That led to additional, incorrect grammars. This fixes that by checking for existing known choice lists and expanding them with the missing members, if necessary. Fixes #52 Fixes #71 Signed-off-by: Moritz Barsnick <moritz.barsnick@chargebyte.com>
barsnick
force-pushed
the
bugfix/duplicated_abstract_extension_GitHub_issue_52
branch
from
5a9d1a6 to
69204d1
Compare
Contributor
Author
Woah, thanks! I have no idea how that could happen. In #52, the submitter also kindly confirmed the fix, and I also did a manual test (as well as our usual local regression tests). |
SebaLukas
approved these changes
Nov 19, 2024
Member
SebaLukas
left a comment
SebaLukas
left a comment
There was a problem hiding this comment.
👍 tested with libcbv2g (unit tests)
chausGit
approved these changes
Nov 20, 2024
barsnick
deleted the
bugfix/duplicated_abstract_extension_GitHub_issue_52
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
The code to expand abstract choices ("abstract sequences") with all extended and substituted types incorrectly added an additional grammar, instead of expanding existing ones.
This fixes that issue by checking for existing particle choices which contain the expanded particle, and replacing that choice, instead of always adding it.
This should fix encoding and decoding of ISO 15118-20 ChargeLoop messages, notably the CLReqControlMode and CLResControlMode elements.
Issue ticket number and link
#52
#71
Checklist before requesting a review