Added configuration key MeterPublicKey for OCPP1.6 #1161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
…dded public function to set the public key of the powermeter per connector Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>
Pietfried
force-pushed
the
feature/meter-public-key-support
branch
from
848068b to
9b3d70d
Compare
james-ctc
reviewed
Dec 2, 2025
Member
james-ctc
left a comment
james-ctc
left a comment
There was a problem hiding this comment.
General
especially for header files basic types as function arguments shouldn't be const.
e.g. std::uint32_t connector_id rather than const std::uint32_t connector_id
(it does have a meaning for the function implementation)
| } | ||
|
|
||
| namespace { | ||
| template <typename T> std::optional<T> parse_meter_public_key_index(const std::string& input) { |
Member
There was a problem hiding this comment.
is there any situation where parse_meter_public_key_index will be called where T != uint32?
Contributor
Author
There was a problem hiding this comment.
Removed the template
| const std::string& s = key.get(); | ||
| const auto connector_id_opt = parse_meter_public_key_index<uint32_t>(s); | ||
|
|
||
| if (connector_id_opt.has_value() == false) { |
Member
There was a problem hiding this comment.
in other places if (!…) is used, which is preferable, rather than if (… == false)
| return std::nullopt; | ||
| } | ||
|
|
||
| const uint32_t connector_id = connector_id_opt.value(); |
Member
There was a problem hiding this comment.
safer to be const auto especially since connector_id_opt is auto.
Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>
james-ctc
approved these changes
Dec 9, 2025
hikinggrass
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The implementation for this configuration key follows the requirements of the OCA Eichrecht Whitepaper
The format the new configuration keys are reported is:
MeterPublicKey[n] where n is the id of the respective connector
Issue ticket number and link
Companion PR: EVerest/everest-core#1599
Checklist before requesting a review