Binding json default construct to use initializer list based constructor #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you! |
hikinggrass
force-pushed
the
kh-binding-json-default-constructor-to-use-initializer-list
branch
from
b5a6167 to
1494759
Compare
GCC 7.3 generates a null string for json({}), and not {}.
With this workaround, the right constructor is selected providing {}.
This is based on #178 but fixes the code generator to extend the fix to all messages of OCPP 1.6 and 2.0.1
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Pietfried
force-pushed
the
kh-binding-json-default-constructor-to-use-initializer-list
branch
from
1494759 to
f04fc57
Compare
Pietfried
approved these changes
Oct 2, 2023
hikinggrass
deleted the
kh-binding-json-default-constructor-to-use-initializer-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC 7.3 generates a null string for json({}), and not {}. With this workaround, the right constructor is selected providing {}.
This is based on #178 but fixes the code generator to extend the fix to all messages of OCPP 1.6 and 2.0.1