OCPP201: Improved handling of ChangeAvailability.req #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pietfried <pietgoempel@gmail.com>
marcemmers
requested changes
Oct 13, 2023
lib/ocpp/v201/charge_point.cpp
Outdated
Comment on lines
902
to
906
| if (this->evses.at(evse.value().id)->has_active_transaction()) { | ||
| return true; | ||
| } else { | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (this->evses.at(evse.value().id)->has_active_transaction()) { | |
| return true; | |
| } else { | |
| return false; | |
| } | |
| return this->evses.at(evse.value().id)->has_active_transaction(); |
lib/ocpp/v201/charge_point.cpp
Outdated
| return (operational_status == OperationalStatusEnum::Inoperative and | ||
| connector_status == ConnectorStatusEnum::Unavailable) or | ||
| (operational_status == OperationalStatusEnum::Operative and | ||
| (connector_status != ConnectorStatusEnum::Unavailable or connector_status != ConnectorStatusEnum::Faulted)); |
Contributor
There was a problem hiding this comment.
This last statement is always true since it can't be Unavailable and Faulted at the same time.
Also, maybe easier to read using a switch for one of the enums?
Signed-off-by: pietfried <pietgoempel@gmail.com>
marcemmers
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduledinstead ofAcceptedto a ChangeAvailability.req(status=Operative) - this has been fixed and is required by G03.FR.03 and G04.FR.04