added is_integer and is_decimal functions to device model validation #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pietfried <pietgoempel@gmail.com>
Pietfried
requested review from
hikinggrass and
marcemmers
and removed request for
marcemmers
marcemmers
reviewed
Oct 17, 2023
Co-authored-by: marcemmers <35759328+marcemmers@users.noreply.github.com> Signed-off-by: Piet Gömpel <37657534+Pietfried@users.noreply.github.com>
marcemmers
reviewed
Oct 17, 2023
lib/ocpp/v201/device_model.cpp
Outdated
| return true; | ||
| } | ||
| } catch (const std::exception& e) { | ||
| return false; |
Contributor
There was a problem hiding this comment.
Should we print here what failed so it's at least not silent?
Contributor
Author
There was a problem hiding this comment.
Yes we could, although in this function we dont have a lot of context that we can use (no component and variable names)
Contributor
There was a problem hiding this comment.
What about moving the whole try catch to the next layer then? The exception would tell something about what went wrong at least.
Contributor
Author
There was a problem hiding this comment.
Yep Ill have a look and add this
Signed-off-by: pietfried <pietgoempel@gmail.com>
Signed-off-by: pietfried <pietgoempel@gmail.com>
marcemmers
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.