Added disconnected callback to websocket to track disconnected_time (for OfflineThreshold) correctly #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pietfried <pietgoempel@gmail.com>
Pietfried
force-pushed
the
pg-offline-disconnected-time
branch
from
c1521fa to
166f53e
Compare
marcemmers
approved these changes
Nov 1, 2023
Contributor
marcemmers
left a comment
marcemmers
left a comment
There was a problem hiding this comment.
Looks good! Also nice to see we could simplify by using the status of the websocket itself 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed_callback isn't always executed when the websocket disconnects / fails. The websocket attempts to reconnect independently without executing the closed callback in certain situations. Therefore a disconnected_callback is added to the websocket in order to notify the chargepoint in case of a disconnect, so that the disconnected_time can be tracked properly