Skip to content

Conversation

@klemmpnx
Copy link
Contributor

This PR:

  • update OCPP 201 standardized schema via script:
  • add variable WebsocketPongTimeout in schema (already used in ChargePoint / manually added to
  • corrects usage of required "SecurityCtrlrIdentity" in "SecurityCtrlr" (key must be property key not variable name)
  • add new struct RequiredComponentVariable as subclass of ComponentVariable for required variables (via script)
  • adjust usages in ChargePoint:
    • get_latest_meter_value_filtered requires "RequiredComponentVariable" (no further adaptions required)
    • authorize_req does not set cacheExpiryDateTime if AuthCacheLifeTime not set (in accordance with spec; this would have failed before if this non-required variable had not been given)

Signed-off-by: Fabian Klemm <fabian.klemm@pionix.de>
Signed-off-by: Fabian Klemm <fabian.klemm@pionix.de>
Signed-off-by: Fabian Klemm <fabian.klemm@pionix.de>
Signed-off-by: Fabian Klemm <fabian.klemm@pionix.de>
…_latest_meter_value_filtered signature)

Signed-off-by: Fabian Klemm <fabian.klemm@pionix.de>
Signed-off-by: Fabian Klemm <fabian.klemm@pionix.de>
@klemmpnx klemmpnx force-pushed the feature/ev-355b-update-schemas-and-enforce-required branch from 54963e2 to 45fa3c7 Compare November 23, 2023 14:12
@klemmpnx
Copy link
Contributor Author

@Pietfried : applied your changes, rebased and tested again

@klemmpnx klemmpnx requested a review from Pietfried November 23, 2023 14:13
@Pietfried Pietfried self-requested a review November 23, 2023 19:54
Copy link
Contributor

@Pietfried Pietfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default ciphersuites have been changed in the meantime:
#274

Co-authored-by: Piet Gömpel <37657534+Pietfried@users.noreply.github.com>
Signed-off-by: Fabian Klemm <fabian.klemm@pionix.de>
@klemmpnx klemmpnx requested a review from Pietfried November 27, 2023 09:25
@klemmpnx klemmpnx merged commit 776f5c0 into main Nov 27, 2023
@klemmpnx klemmpnx deleted the feature/ev-355b-update-schemas-and-enforce-required branch November 27, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants