-
Notifications
You must be signed in to change notification settings - Fork 66
EV 355: part II: update schemas and enforce required property #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
klemmpnx
merged 7 commits into
main
from
feature/ev-355b-update-schemas-and-enforce-required
Nov 27, 2023
Merged
EV 355: part II: update schemas and enforce required property #272
klemmpnx
merged 7 commits into
main
from
feature/ev-355b-update-schemas-and-enforce-required
Nov 27, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pietfried
requested changes
Nov 22, 2023
Signed-off-by: Fabian Klemm <fabian.klemm@pionix.de>
Signed-off-by: Fabian Klemm <fabian.klemm@pionix.de>
Signed-off-by: Fabian Klemm <fabian.klemm@pionix.de>
Signed-off-by: Fabian Klemm <fabian.klemm@pionix.de>
…_latest_meter_value_filtered signature) Signed-off-by: Fabian Klemm <fabian.klemm@pionix.de>
Signed-off-by: Fabian Klemm <fabian.klemm@pionix.de>
54963e2 to
45fa3c7
Compare
Contributor
Author
|
@Pietfried : applied your changes, rebased and tested again |
Pietfried
approved these changes
Nov 23, 2023
Pietfried
requested changes
Nov 23, 2023
Contributor
Pietfried
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default ciphersuites have been changed in the meantime:
#274
Co-authored-by: Piet Gömpel <37657534+Pietfried@users.noreply.github.com> Signed-off-by: Fabian Klemm <fabian.klemm@pionix.de>
Pietfried
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
authorize_reqdoes not set cacheExpiryDateTime if AuthCacheLifeTime not set (in accordance with spec; this would have failed before if this non-required variable had not been given)