Do not send InstallScheduled when changing connectors to unavailable #276
Conversation
This was accidentally sent and is completely wrong here Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
lib/ocpp/v201/charge_point.cpp
Outdated
|
|
||
| const auto transaction_active = this->any_transaction_active(std::nullopt); | ||
| if (transaction_active) { | ||
| this->firmware_status = FirmwareStatusEnum::InstallScheduled; |
There was a problem hiding this comment.
I will test your solution. But as we are already sending InstallScheduled from our 'core', will that go well?
Anyway, will test, let you know!
There was a problem hiding this comment.
That might be an issue, maybe we can use another method of determining if transactions are still running that doesn't involve this part of the code in libocpp
There was a problem hiding this comment.
This is indeed failing L_15. Because InstallScheduled is already sent (from the 'core' application), it will send it again.
It is a bit strange that all firmware statusses are sent from 'core' and only one is sent from here isn't it?
But keeping a variable that stores the last sent status will probably do the trick as well.
There was a problem hiding this comment.
You're right, this isn't the proper place for it. I'll remove the commit from this PR and figure something out for L_15
hikinggrass
force-pushed
the
kh-fix-wrong-install-scheduled
branch
from
1ac13ce to
62922d6
Compare
This was accidentally sent all the time but is only valid if there is a transaction ongoing
Fix verified against OCTT tests
TC_L_01_CS
TC_L_02_CS
TC_L_03_CS
TC_L_05_CS
TC_L_06_CS
TC_L_07_CS
TC_L_08_CS
TC_L_10_CS
TC_L_15_CS
TC_L_18_CS