Skip to content

Changed parameter from std::string to IdToken in on_transaction_finished #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Pietfried merged 2 commits into from
Jan 2, 2024
Merged

Changed parameter from std::string to IdToken in on_transaction_finished #388

Pietfried merged 2 commits into from
Jan 2, 2024

Conversation

@Pietfried
Copy link
Contributor

@Pietfried Pietfried commented Jan 2, 2024 •
edited
Loading

  • using proper IdToken argument in on_transaction_finished
  • removed hardcoded ISO14443 type

@Pietfried
changed id_token parameter of on_transaction_finished to ocpp::v201::…
f0aeb04 
…IdTokenType

Signed-off-by: pietfried <pietgoempel@gmail.com>
@Pietfried
clang format
5fba613 
Signed-off-by: pietfried <pietgoempel@gmail.com>
@Pietfried Pietfried linked an issue Jan 2, 2024 that may be closed by this pull request
TransactionEvent Ended always uses (hardcoded) ISO14443 token type #304
Closed
@Pietfried Pietfried requested a review from mennodegraaf January 2, 2024 15:52
@Pietfried Pietfried mentioned this pull request Jan 2, 2024
Merged
@Pietfried Pietfried merged commit 7888cd6 into main Jan 2, 2024
@Pietfried Pietfried deleted the pg-v201-id-token-param branch January 2, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mennodegraaf mennodegraaf mennodegraaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TransactionEvent Ended always uses (hardcoded) ISO14443 token type

3 participants

@Pietfried @mennodegraaf