Libwebsockets: Fix message loss on reconnect #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cornelius Claussen <cc@pionix.de>
AssemblyJohn
reviewed
Feb 8, 2024
AssemblyJohn
reviewed
Feb 8, 2024
Signed-off-by: Cornelius Claussen <cc@pionix.de>
Signed-off-by: Cornelius Claussen <cc@pionix.de>
Signed-off-by: AssemblyJohn <ioan.bogdann@gmail.com>
Signed-off-by: AssemblyJohn <ioan.bogdann@gmail.com>
Signed-off-by: AssemblyJohn <ioan.bogdann@gmail.com>
AssemblyJohn
approved these changes
Feb 9, 2024
Signed-off-by: AssemblyJohn <ioan.bogdann@gmail.com>
AssemblyJohn
force-pushed
the
bugfix/libws-fix-message-lost-after-reconnect
branch
from
246a706 to
32a1996
Compare
Signed-off-by: AssemblyJohn <ioan.bogdann@gmail.com>
corneliusclaussen
deleted the
bugfix/libws-fix-message-lost-after-reconnect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using libwebsockets, the first message after a reconnect could not be sent as the connect handler to the libocpp was called from the wrong thread.