fix: libwebsockets retry on no-connection #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-ctc
requested review from
Pietfried,
hikinggrass,
maaikez and
marcemmers
as code owners
james-ctc
force-pushed
the
fix/tls-reconnect-on-no-network
branch
2 times, most recently
from
42f15fd to
d2ef365
Compare
AssemblyJohn
reviewed
Mar 6, 2024
AssemblyJohn
approved these changes
Mar 6, 2024
AssemblyJohn
approved these changes
Mar 6, 2024
When there is no internet connetcion then DNS lookups and other IP activities can take a while to return. A 60 second connect timeout was expiring and reconnect attempts were not scheduled. Code updated to ensure that reconnection attempts are still tried. fix: shared pointer conn_data not always checked for nullptr Code updated to make con_data thread-safe and ensure that nullptr checks are applied. Signed-off-by: James Chapman <james.chapman@pionix.de>
Signed-off-by: James Chapman <james.chapman@pionix.de>
Signed-off-by: James Chapman <james.chapman@pionix.de>
james-ctc
force-pushed
the
fix/tls-reconnect-on-no-network
branch
from
2580d5c to
4072e81
Compare
Contributor
|
All cool, can be merged in the current libwebsocket beta. |
Pietfried
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
When there is no internet connection then DNS lookups and other IP activities can take a while to return. A 60 second connect timeout was expiring and reconnect attempts were not scheduled.
Code updated to ensure that reconnection attempts are still tried.
fix: shared pointer conn_data not always checked for nullptr
Code updated to make con_data thread-safe and ensure that nullptr checks are applied.
Issue ticket number and link
Checklist before requesting a review