Support configurable TxStart and TxStop points #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pietfried
requested review from
hikinggrass,
maaikez and
marcemmers
as code owners
3 tasks
marcemmers
reviewed
Apr 2, 2024
Pietfried
force-pushed
the
feature/ocpp201-support-configurable-tx-start-stop
branch
2 times, most recently
from
032fb2c to
f32452a
Compare
marcemmers
requested changes
Apr 4, 2024
Contributor
marcemmers
left a comment
marcemmers
left a comment
There was a problem hiding this comment.
I think there are some use cases missing that we can support
Pietfried
force-pushed
the
feature/ocpp201-support-configurable-tx-start-stop
branch
from
e10059b to
03a8f6f
Compare
hikinggrass
approved these changes
Apr 5, 2024
Member
hikinggrass
left a comment
hikinggrass
left a comment
There was a problem hiding this comment.
looks good, I agree with marcs comments, this could probably be addressed
* Now also handling TransactionEvent.conf for Updated (not only Started) * IdToken became optional for TransactionEvent(Started). To be able to support e.g. TxStartPoint EVConnected * Added on_authorized handler to report when an Evse has been authorized. This allows sending of TransactionEvent(Updated) with IdToken * Added trigger_reason as argument to on_charging_state_changed Co-authored-by: marcemmers <35759328+marcemmers@users.noreply.github.com> Signed-off-by: Piet Gömpel <37657534+Pietfried@users.noreply.github.com> Signed-off-by: pietfried <pietgoempel@gmail.com>
…rom valuesList Signed-off-by: pietfried <pietgoempel@gmail.com>
Pietfried
force-pushed
the
feature/ocpp201-support-configurable-tx-start-stop
branch
from
03a8f6f to
a95e494
Compare
* Stopping transactions if running on multiple evses in case status is not Accepted Signed-off-by: pietfried <pietgoempel@gmail.com>
marcemmers
reviewed
Apr 9, 2024
lib/ocpp/v201/charge_point.cpp
Outdated
| } else { | ||
| // add every evse_id with active transaction and given token | ||
| for (const auto& [evse_id, evse] : this->evses) { | ||
| if (evse->get_transaction() != nullptr and evse->get_transaction()->id_token.has_value()) { |
Contributor
There was a problem hiding this comment.
Nit: get the transaction just once and then use that temporary variable.
marcemmers
approved these changes
Apr 9, 2024
Signed-off-by: pietfried <pietgoempel@gmail.com>
folkengine
pushed a commit
to US-JOET/libocpp
that referenced
this pull request
Apr 15, 2024
Changes to be able to support configurable TxStart and TxStop points: * Now also handling TransactionEvent.conf for Updated (not only Started) * IdToken became optional for TransactionEvent(Started). To be able to support e.g. TxStartPoint EVConnected * Added on_authorized handler to report when an Evse has been authorized. This allows sending of TransactionEvent(Updated) with IdToken * Added trigger_reason as argument to on_charging_state_changed * make TxStartPoint and TxStopPoint RW and remove ParkingBayOccupancy from valuesList --------- Signed-off-by: Piet Gömpel <37657534+Pietfried@users.noreply.github.com> Signed-off-by: pietfried <pietgoempel@gmail.com> Co-authored-by: marcemmers <35759328+marcemmers@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Changes to be able to support configurable TxStart and TxStop points.
This PR does not implement handling for configurable TxStart and TxStop points within libocpp, but it allows the consumer application to implement this by calling on_transaction_started and on_transaction_finished at the specified TxStart and TxStop points.
Issue ticket number and link
The companion PR in everest-core: EVerest/everest-core#611 . The actual support for configurable TxStart and TxStop points is implemented there. The transaction_handler.hpp could be moved to libocpp at a later stage, to have support actual for configurable TxStart and TxStop points within libocpp.
Checklist before requesting a review